Commit 2023-01-04 22:44 d1723c04
View on Github →refactor(group_theory/perm/cycle/basic): Consolidate API (#17898) Reorganise and complete the cycle API:
- Previously,
is_cyclewas spelling out the definition ofsame_cycle. Now use it explicitly. - Change binder to semi-implicit in the definition of
is_cycle. - Add lemmas and iff aliases.
- Golf existing proofs using those (mostly invisible from the diff because git decided I am moving the
is_cycleAPI) - Improve lemma names, mostly for better dot notation.
New lemmas
maps_to.extend_domainsurj_on.extend_domainbij_on.extend_domainextend_domain_powextend_domain_zpowsame_cycle.rfleq.same_cyclesame_cycle.conjsame_cycle_conjsame_cycle_pow_right_iffsame_cycle_zpow_right_iffsame_cycle.pow_leftsame_cycle.pow_rightsame_cycle.zpow_leftsame_cycle.zpow_leftsame_cycle.of_powsame_cycle.of_zpowsame_cycle_subtype_permsame_cycle.subtype_permsame_cycle_extend_domainis_cycle.conjis_cycle.pow_eq_one_iff'is_cycle.pow_eq_one_iff''
Renames
order_of_is_cycle→is_cycle.order_ofis_cycle.is_cycle_conj→is_cycle.conjis_cycle_of_is_cycle_pow→is_cycle.of_powis_cycle_of_is_cycle_zpow→is_cycle.of_zpowsame_cycle_cycle→is_cycle_iff_same_cyclemem_support_pos_pow_iff_of_lt_order_of→support_pow_of_pos_of_lt_order_ofand change the statement to talk about unextensionalised finset equality