Commit 2024-11-05 19:57 0d0d4013

View on Github →

chore: split RingTheory.RootsOfUnity.Basic (#18669) As a preliminary step before adding new material to the RootsOfUnity files, this splits off a large part of RingTheory.RootsOfUnity.Basic into a new file RingTheory.RootsOfUnity.PrimitiveRoots.

  • The current Basic file had almost 1000 lines
  • The material that is split off is everything relying on IsPrimitiveRoot, what remains does not depend on that
  • Some downstream files do not need IsPrimitiveRoot I've also cleaned up some of the import lists in the files I touched.

Estimated changes

deleted theorem IsPrimitiveRoot.disjoint
deleted theorem IsPrimitiveRoot.injOn_pow
deleted theorem IsPrimitiveRoot.inv
deleted theorem IsPrimitiveRoot.inv_iff
deleted theorem IsPrimitiveRoot.isUnit
deleted theorem IsPrimitiveRoot.mk_of_lt
deleted theorem IsPrimitiveRoot.neZero'
deleted theorem IsPrimitiveRoot.ne_one
deleted theorem IsPrimitiveRoot.neg_one
deleted theorem IsPrimitiveRoot.one
deleted theorem IsPrimitiveRoot.pow
deleted theorem IsPrimitiveRoot.pow_inj
deleted theorem IsPrimitiveRoot.unique
deleted theorem IsPrimitiveRoot.zero
deleted structure IsPrimitiveRoot
deleted theorem mem_primitiveRoots
deleted def primitiveRoots
deleted theorem primitiveRoots_zero
added theorem IsPrimitiveRoot.inv
added theorem IsPrimitiveRoot.isUnit
added theorem IsPrimitiveRoot.ne_one
added theorem IsPrimitiveRoot.one
added theorem IsPrimitiveRoot.pow
added theorem IsPrimitiveRoot.unique
added theorem IsPrimitiveRoot.zero
added structure IsPrimitiveRoot
added theorem mem_primitiveRoots
added def primitiveRoots
added theorem primitiveRoots_zero