Commit 2025-01-24 19:43 395adf24

View on Github →

feat: define the Cartan matrix of a root pairing relative to a base (#20999) Also adding RootPairing.IsValuedIn (together with some API) since this enables us to define an integer-valued Cartan matrix for crystallographic pairings. More importantly, RootPairing.IsValuedIn is also the missing piece to generalise (and unify) some results which currently require ordered scalars such as RootPairing.coxeterWeight_mem_set_of_isCrystallographic but this work is left for a future PR (mostly to simplify review).

Estimated changes