Commit 2024-08-05 10:13 4d93d88d
View on Github →refactor: use consistent names for forgetful smul structures (#15500) Moves:
AddCommMonoid.natModule
->AddCommMonoid.toNatModule
AddCommGroup.intModule
->AddCommGroup.toIntModule
algebraNat
->Semiring.toNatAlgebra
algebraInt
->Ring.toIntAlgebra
algebraRat
->DivisionRing.toRatAlgebra
AddCommGroup.natModule.unique
->AddCommMonoid.uniqueNatModule
AddCommGroup.intModule.unique
->AddCommGroup.uniqueIntModule
The premise here is that the conversion fromAddCommGroup
toAddCommMonoid
is not really any different from converting fromAddCommGroup
toModule ℤ
; and so both should be named with theto*
naming convention. Tihs also brings the naming of theModule
andAlgebra
instances into alignment. I chosetoNatModule
instead oftoModuleNat
to match the prose, ℕ-module. This fits a common naming convention if you viewModule
as infix, as we do with various other lean functions without actual infix notation.