Commit 2026-11-20 15:41 66f20c74

View on Github →

refactor(Algebra): generalize AlgEquiv to non-unital (#45954) This refactors AlgEquiv to allow for non-unital algebras. More specifically, we weaken the type class assumptions from:

structure AlgEquiv (R A B : Type*) [CommSemiring R] [Semiring A] [Semiring B]
  [Algebra R A] [Algebra R B]

to

structure AlgEquiv (R A B : Type*) [Add A] [Add B] [Mul A] [Mul B] [SMul R A] [SMul R B]

Instead of a commutes' field, we now have a map_smul' field. We also include a definition AlgEquiv.ofCommutes which takes in a RingEquiv and a commutes' field to match before and for convenience (AlgEquiv.ofRingEquiv is this, so is deprecated). StarAlgEquiv now extends AlgEquiv. Breaking change: for algebra equivalences { toRingEquiv := fooRingEquiv, commutes' := _ }, you will now need to change this to AlgEquiv.ofCommutes fooRingEquiv _. Or you can change the commutes' field to map_smul' with a slightly different proof.

Estimated changes