Commit 2023-06-21 05:36 719a2170

View on Github →

chore: reorder universe variables in Cardinal.lift_le and Cardinal.lift_mk_le (#5325) Cardinal.lift_le and Cardinal.lift_mk_le have their universes out of order, in the sense that persistently through the rest of the library we need to specify the 2nd universe (resp 3rd), while the others are solved by unification. This PR reorders the universes so it's easier to specify the thing you need to specify! (This PR doesn't get rid of all the occurrences of \.\{_, in the library, but I'd like to do that later.) I do have a hidden agenda here, which is that I've been experimenting with solutions to the dreaded "Can't solve max u v = max v ?u" universe unification issue (which is making life hellish forward porting https://github.com/leanprover-community/mathlib/pull/19153), and my favourite (but still hacky) solution doesn't like some of the occasions where we reference a lemma filling in some of its universe arguments with _ but then fully specify a later one. (e.g. rw [← lift_le.{_, max u v}, lift_lift, lift_mk_le.{_, _, v}] in ModelTheory/Skolem.lean). Hence the cleanup proposed in this PR makes my life easier working on these experiments. :-)

Estimated changes