Commit 2023-02-18 20:01 7e1713a1
View on Github →feat: port LinearAlgebra.Quotient (#2286) porting notes:
- Adding type ascriptions to
mkormk xand friends greatly speeds up elaboration issues. - What is the proper casing convention for
mkqorliftq(and variants). Is ismkq, ormkQ? Edit: we've gone withmkQ,liftQandmapQ. - How should
submodule.comap_mkq.rel_isobe called according to our naming conventions? Edit: unclear, but here it's been changed toSubmodule.comapMkQRelIso. Why can't Lean fill inEdit: apparently this was never a thing in Lean 3 either.optParamsautomatically insimporrw?- Why did I need to add an
optParaminSubmodule.Quotient.equiv_applythat wasn't needed in Lean 3, so this has been#aligned with anₓ, and why didn'tsimpsgenerate this lemma? - There are some instances I feel like we may want to be
default_instances, but I'm not sure. Edit: this can always be added later if necessary, so it's not urgent here. Zulip