Commit 2023-02-18 20:01 7e1713a1
View on Github →feat: port LinearAlgebra.Quotient (#2286) porting notes:
- Adding type ascriptions to
mk
ormk x
and friends greatly speeds up elaboration issues. - What is the proper casing convention for
mkq
orliftq
(and variants). Is ismkq
, ormkQ
? Edit: we've gone withmkQ
,liftQ
andmapQ
. - How should
submodule.comap_mkq.rel_iso
be called according to our naming conventions? Edit: unclear, but here it's been changed toSubmodule.comapMkQRelIso
. Why can't Lean fill inEdit: apparently this was never a thing in Lean 3 either.optParams
automatically insimp
orrw
?- Why did I need to add an
optParam
inSubmodule.Quotient.equiv_apply
that wasn't needed in Lean 3, so this has been#align
ed with anₓ
, and why didn'tsimps
generate this lemma? - There are some instances I feel like we may want to be
default_instance
s, but I'm not sure. Edit: this can always be added later if necessary, so it's not urgent here. Zulip