Commit 2025-07-15 08:10 92dbb752

View on Github →

chore: rename arguments to Matrix.submatrix (#24883) I'm suggesting this change for the following reasons: (1) managing expectations — r_reindex looks more like a propositional argument at first glance (2) the original naming does not do justice to its motivation — there is nothing called r and c here — it would need to be row_reindex and col_reindex or something like that (if we wanted to use the convention for naming constants even tho we are naming a variable here)

Estimated changes