Commit 2024-11-13 18:58 a0765bc8

View on Github →

chore: rename a bunch of stuff (#18886) These are (in my opinion) improperly named things that I encountered over time. Happy to remove any of them if there are disagreements.

  • Remove manual instance names IccManifold and Icc_smooth_manifold. They're improper because the former is a ChartedSpace instance, while the latter is a SmoothManifoldWithCorners instance. As instances, they also probably shouldn't come up so high when searching for "Manifold" in the docs. Their names are now automatically generated, just like the two instances below them.
  • Rename ManifoldWithCorners.metrizableSpace to Manifold.metrizableSpace.
  • Rename apply_(h)fdifferential to (h)fdifferential_apply. This is to match the semantics of e.g. ite_apply and apply_ite.

Estimated changes