Commit 2026-02-04 23:34 ba07a5d5

View on Github →

refactor(Tactic/Ring): move most ring code into Common.lean (#34837) This is in preparation of #34734, which generalizes the code in Ring/Common for use in the coming algebra tactic. Moving the core of ring to Common makes the diff of said PR significantly more readable, as requested by @Vierkantor here Unfortunately a couple of the functions moved to Ring/Common will have to be moved back to Ring/Basic as they are specific to ring. These are namely the sections for n/zsmul and evalCast. They can't stay in Ring/Basic since eval depends on them.

Estimated changes

deleted structure Mathlib.Tactic.Ring.Cache
deleted inductive Mathlib.Tactic.Ring.ExBase
deleted inductive Mathlib.Tactic.Ring.ExProd
deleted inductive Mathlib.Tactic.Ring.ExSum
deleted inductive Mathlib.Tactic.Ring.Overlap
deleted structure Mathlib.Tactic.Ring.Result
added structure Mathlib.Tactic.Ring.Cache
added inductive Mathlib.Tactic.Ring.ExSum