Commit 2025-03-04 14:42 cdc8210e

View on Github →

chore(AlgebraicGeometry/EllipticCurve/*): remove redundant names (#22479) Clean up a few redundant/bad names:

  • nonsingular_zero_of_Δ_ne_zero is a special case of nonsingular_of_Δ_ne_zero, which itself is a (very easy) special case of equation_iff_nonsingular_of_Δ_ne_zero, and similarly with nonsingular and equation_iff_nonsingular
  • equation_neg(_of) and nonsingular_neg(_of) are special cases of equation_neg_iff and nonsingular_neg_iff
  • mapFun and toClassFun are function versions of the group homomorphisms map and toClass
  • mk_XYIdeal'_mul_mk_XYIdeal'_of_Yeq should have been named mk_XYIdeal'_neg_mul according to naming conventions
  • all instance names since they can be named automatically

Estimated changes