Commit 2026-03-23 08:24 e342913b

View on Github →

chore(Order/UpperLower/Closure): use to_dual (#36969) This PR tags upperClosure with to_dual.

  • to_dual was not happy with the proof of upperClosure_image. I replaced it with a proof with less defeq abuse, by tagging UpperSet.map with simps.
  • to_dual is not happy with the galois connections, because they are between the order and a set-containment order, and only one of the two is translated by to_dual. Hence, the proofs using the galois connection cannot be translated automatically, and we need to use to_dual existing. I changed two proofs to avoid this dependency.
  • I changed the to_dual_insert_cast proof of GaloisInsertion to clarify what is going on there.
  • DecidablePred was being translated to DecidableSucc, so I added a fix in the abbreviation dictionary.

Estimated changes

deleted theorem LowerSet.Iic_sup_erase
deleted theorem LowerSet.coe_erase
deleted theorem LowerSet.coe_sdiff
deleted def LowerSet.erase
deleted theorem LowerSet.erase_eq
deleted theorem LowerSet.erase_idem
deleted theorem LowerSet.erase_le
deleted theorem LowerSet.erase_lt
deleted theorem LowerSet.erase_sup_Iic
deleted theorem LowerSet.iSup_Iic
deleted def LowerSet.sdiff
deleted theorem LowerSet.sdiff_le_left
deleted theorem LowerSet.sdiff_lt_left
deleted theorem LowerSet.sdiff_singleton
modified theorem UpperSet.erase_eq
modified theorem UpperSet.erase_idem
modified theorem UpperSet.le_erase
modified theorem UpperSet.le_sdiff_left
modified theorem UpperSet.lt_erase
modified theorem UpperSet.lt_sdiff_left
modified theorem UpperSet.sdiff_singleton
deleted theorem bddAbove_lowerClosure
deleted theorem coe_lowerClosure
deleted theorem le_upperClosure
deleted def lowerClosure
deleted theorem lowerClosure_empty
deleted theorem lowerClosure_eq
deleted theorem lowerClosure_eq_bot_iff
deleted theorem lowerClosure_eq_top
deleted theorem lowerClosure_eq_top_iff
deleted theorem lowerClosure_image
modified theorem lowerClosure_le
deleted theorem lowerClosure_min
deleted theorem lowerClosure_sUnion
deleted theorem lowerClosure_singleton
deleted theorem lowerClosure_univ
deleted theorem mem_lowerClosure
deleted theorem subset_lowerClosure
deleted theorem upperBounds_lowerClosure
modified theorem upperClosure_eq
modified theorem upperClosure_eq_top_iff