Commit 2023-02-01 05:31 f2c39613
View on Github →feat: port Data.Finsupp.Basic (#1949) porting notes:
simps
was not working in various places due to thenoncomputable
, so I had to manually add some lemmas it would have generated. See here: https://leanprover.zulipchat.com/#narrow/stream/287929-mathlib4/topic/finding.20.60simps.60.20lemmas- Lean 4 really had trouble inferring arguments to
mapRange_comp
for some reason as compared to Lean 3 - In several places I had to manually supply decidability instances (from
Classical
). This should probably be investigated. - It looks like the
Sigma.mk.inj
auto-generated lemma was never created. Why? - In one place,
ext
didn't fire the same way in Lean 3 versus Lean 4; I just copied the output ofext?
from Lean 3, but we should understand what went wrong.