Commit 2021-04-24 15:20 46ceb36e
View on Github →refactor(*): rename semimodule
to module
, delete typeclasses module
and vector_space
(#7322)
Splitting typeclasses between semimodule
, module
and vector_space
was causing many (small) issues, so why don't we just get rid of this duplication?
This PR contains the following changes:
- delete the old
module
andvector_space
synonyms forsemimodule
- find and replace all instances of
semimodule
andvector_space
tomodule
- (thereby renaming the previous
semimodule
typeclass tomodule
) - rename
vector_space.dim
tomodule.rank
(in preparation for generalizing this definition to all modules) - delete a couple
module
instances that have now become redundant This find-and-replace has been done extremely naïvely, but it seems there were almost no name clashes and no "clbuttic mistakes". I have gone through the full set of changes, finding nothing weird, and I'm fixing any build issues as they come up (I expect less than 10 declarations will cause conflicts). Zulip discussion: https://leanprover.zulipchat.com/#narrow/stream/113488-general/topic/module.20from.20semimodule.20over.20a.20ring A good example of a workaround required by themodule
abbreviation is thetriv_sq_zero_ext.module
instance.