Commit 2021-04-06 01:49 61d2ad05
View on Github →chore(algebra/char_p/basic): uniformise notation and weaken some assumptions (#6765)
I had looked at this file in an earlier PR and decided to come back to uniformise the notation, using always R
and never α
for the generic type of the file.
While I was at it, I started also changing
- some
semiring
assumptions toadd_monoid + has_one
, - some
ring
assumptions toadd_group + has_one
. In the long run, I think that the characteristic of a ring should be defined as the order of1
in the additive submonoid, but this is not what I am doing at the moment! Here is a related Zulip discussion: https://leanprover.zulipchat.com/#narrow/stream/116395-maths/topic/char_zero